[ 
https://issues.apache.org/jira/browse/TOBAGO-1372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13924096#comment-13924096
 ] 

Bernhard Stadler commented on TOBAGO-1372:
------------------------------------------

Hi Udo,

Thanks for the change. 

{quote}
Why do you use the rowSpan=2? In the exemple it is not needed. But I assume, 
your real application is more complex.
{quote}
This is because the XHTML files are generated from a large legacy application 
(so manually adjusting the XHTML is not an option). I have to make sure that 
the space originally taken by the table is reflected correctly in the grid. As 
I wrote in the report, I can work around this (in a not-so-beautiful way) by 
putting an empty panel that occupies these grid cells into the row below. 

{quote}
I think the problem is, that the height of the 2 (or n) rows can't be computed.
{quote}
So does this mean that using rowSpan >= 2 for 'auto' rows is always illegal? 
Otherwise putting the sheet inside a tc:panel (like in the attached 
tobago-sheet-panel-rowSpan-bug.xhtml) should work because the sheet has rowSpan 
= 1.

To me it would make sense to allow rowSpan >= 2 for 'auto' rows - it would only 
mean that the height of all spanned rows together has to be >= the height of 
the element. I.e. as far as the rows aren't already high enough because of 
other widgets in other columns of the spanned rows, each of the spanned auto 
row's height has to be increased by the missing amount divided by the number of 
spanned auto rows.
This would even make sense when different kinds of rows are being spanned, 
including '*' or constant height rows. 

> tc:sheet with rowSpan in "auto" row gets 0 height
> -------------------------------------------------
>
>                 Key: TOBAGO-1372
>                 URL: https://issues.apache.org/jira/browse/TOBAGO-1372
>             Project: MyFaces Tobago
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 2.0.0-alpha-3
>         Environment: JSF 2.0.1.1 / Servlet 3.0.1 / Jetty
>            Reporter: Bernhard Stadler
>         Attachments: Sheet in panel with rowSpan=2.jpg, Sheet with 
> rowSpan=2.jpg, tobago-sheet-panel-rowSpan-bug.xhtml, 
> tobago-sheet-rowSpan-bug.xhtml
>
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> I have a tobago page having a grid layout with "auto" rows and "*" columns. 
> When I put a tc:sheet with a rowSpan >= 2 on it, the table doesn't get 
> rendered. Without rowSpan, this works nicely.
> When I try removing the rowSpan from tc:sheet and putting the sheet inside a 
> panel with rowSpan >= 2, the sheet does get rendered, but subsequent elements 
> overlap the table as if it had height = 0px.
> The only workaround I found is giving the sheet rowSpan=1 (instead of n >= 2) 
> and adding a panel with rowSpan=n-1. (However, this doesn't work too well for 
> my use case).
> I'll attach examples for both cases.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to