[ https://issues.apache.org/jira/browse/TRINIDAD-2510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14154943#comment-14154943 ]
Andy Schwartz commented on TRINIDAD-2510: ----------------------------------------- On applying the patch, I see this output: patch -p0 -i ~/patches/jira-2510.patch (Stripping trailing CRs from patch.) patching file trinidad-impl/src/test/java/org/apache/myfaces/trinidadinternal/skin/SkinTestCase.java patch unexpectedly ends in middle of line Hunk #1 succeeded at 76 with fuzz 2. The "patch unexpectedly ends in middle of line" message makes me worried that something might be wrong. Can you double-check that the patch is correct and/or provide a new patch that does not show this message when applied to the Trinidad trunk? > make SkinTestCase more extendable > --------------------------------- > > Key: TRINIDAD-2510 > URL: https://issues.apache.org/jira/browse/TRINIDAD-2510 > Project: MyFaces Trinidad > Issue Type: Improvement > Components: Skinning > Affects Versions: 2.1.0-core > Reporter: Anand V Nath > Priority: Minor > Attachments: jira-2510.patch > > > SkinTestCase which is part of trinidad-impl/test, works with TestSkin enum > which does not offer flexibility. The change proposed is to add an overloaded > method for visiting skins where the skin resource path can be passed as a > String. This will enable test cases extending SkinTestCase to work with any > skin of their choice. > The proposed change is to add this method in SkinTestCase: > /** > * Performs a visit of all style sheet nodes in the specified test > * skin. This overloaded method is useful in extending SkinTestCase to > * create more test cases since TestSkin does not provide all the skins > * that test needs. > */ > protected final void visitStyleSheets(String skinResourcePath, > StyleSheetVisitor visitor) > { > StyleSheetDocument document = SkinTestUtils.parseSkin(skinResourcePath); > > StyleSheetVisitUtils.visitStyleSheets(document.getStyleSheetsAsCollection(), > visitor); > } -- This message was sent by Atlassian JIRA (v6.3.4#6332)