Are you sure Leo? FlowBuilderCDIExtension should exist per WebApp. 2015-12-15 22:39 GMT+01:00 Leonardo Uribe <[email protected]>:
> Hi > > I remember the current solution works in a case where myfaces jars are > shared by different web applications. Suppose a TomEE environment. The > solution proposed in the patch cause a problem when two webapps uses faces > flow, because one app could find the flows of the other one (variable for > FlowBuilderCDIExtension). > > I don't have idea if the solution proposed works in that case, so we need > to check that before apply it. > > regards, > > Leonardo Uribe > > > 2015-12-15 14:58 GMT-05:00 Hank Ibell <[email protected]>: > >> Hello Thomas, >> >> I did think injecting the FlowBuilderCDIExtension would work -- I was >> quite surprised when it did. Also, after looking at the code again, I agree >> that the lists should be ArrayList instead. Thank you for the quick review >> and suggestions! >> >> The new patch has been attached to this email and to the JIRA. >> >> >> Regards, >> Hank Ibell >> >> On Mon, Dec 14, 2015 at 4:09 PM, Thomas Andraschko < >> [email protected]> wrote: >> >>> Hi, >>> >>> i did a small review: >>> >>> 1) Why you don't use @Inject for the FlowBuilderCDIExtension in the >>> FlowBuilderFactoryBean? >>> 2) Why do you use CopyOnWriteArrayList? ArrayList should be fine as the >>> both lists are AppScoped and should only be used on startup. >>> >>> >>> >>> 2015-12-14 21:53 GMT+01:00 Hank Ibell <[email protected]>: >>> >>>> Hello Thomas, >>>> >>>> Thank you for the information. :) I will wait for Leo's review then. >>>> >>>> Regards, >>>> Hank Ibell >>>> >>>> On Mon, Dec 14, 2015 at 3:20 PM, Thomas Andraschko < >>>> [email protected]> wrote: >>>> >>>>> Hi, >>>>> >>>>> first of all: thanks for the patch. >>>>> >>>>> As the last release-vote just passed last week, please have a little >>>>> patience. >>>>> >>>>> AFAIR the flows-feature was the developed by Leo, so it would be the >>>>> best if he could review it. >>>>> Otherwise i will check it. >>>>> >>>>> Regards, >>>>> Thomas >>>>> >>>>> >>>>> 2015-12-14 3:46 GMT+01:00 Hank Ibell <[email protected]>: >>>>> >>>>>> Hello, >>>>>> >>>>>> It has been about a week since MYFACES-4022 [link >>>>>> <https://issues.apache.org/jira/browse/MYFACES-4022>] has been >>>>>> opened and a potential patch has been submitted. There has been no >>>>>> feedback >>>>>> on the issue however. >>>>>> >>>>>> Is there anything else that is needed so that we can resolve this >>>>>> issue as soon as possible? >>>>>> >>>>>> Regards, >>>>>> Hank Ibell >>>>>> >>>>> >>>>> >>>> >>> >> >
