[
https://issues.apache.org/jira/browse/TOBAGO-1852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16389460#comment-16389460
]
ASF GitHub Bot commented on TOBAGO-1852:
----------------------------------------
lofwyr14 commented on a change in pull request #7: TOBAGO-1852 Sheet row to
open a popup does not work
URL: https://github.com/apache/myfaces-tobago/pull/7#discussion_r172821754
##########
File path:
tobago-core/src/main/java/org/apache/myfaces/tobago/internal/renderkit/CommandMap.java
##########
@@ -104,14 +104,16 @@ public static CommandMap merge(final CommandMap m1,
final CommandMap m2) {
c1.merge(c2);
}
} else {
- for (final Map.Entry<ClientBehaviors, Command> entry :
m2.getOther().entrySet()) {
- final ClientBehaviors key = entry.getKey();
- final Command value = entry.getValue();
- if (m1.other.containsKey(key)) {
- final Command command = m1.other.get(key);
- command.merge(value);
- } else {
- m1.addCommand(key, value);
+ if (m1.getOther() != null && m2.getOther() != null) {
Review comment:
Please use "other" instead of "getOther()" for internal calls (performance).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Sheet row to open a popup does not work
> ---------------------------------------
>
> Key: TOBAGO-1852
> URL: https://issues.apache.org/jira/browse/TOBAGO-1852
> Project: MyFaces Tobago
> Issue Type: Bug
> Components: Core, Demo
> Reporter: Udo Schnurpfeil
> Assignee: Henning Noeth
> Priority: Major
> Fix For: 4.2.0
>
>
> # open
> http://tobago-vm.apache.org/demo-4-snapshot/content/20-component/080-sheet/30-event/sheet-event.xhtml
> # Select radio: open popup on click with AJAX
> # Klick on a row
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
