[ 
https://issues.apache.org/jira/browse/MYFACES-4232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16495228#comment-16495228
 ] 

ASF GitHub Bot commented on MYFACES-4232:
-----------------------------------------

ebreijo opened a new pull request #2: MYFACES-4232 Update UIWebsocket signature 
in the JSF 2.3 API
URL: https://github.com/apache/myfaces/pull/2
 
 
   https://issues.apache.org/jira/browse/MYFACES-4232

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Update UIWebsocket signature in the JSF 2.3 API
> -----------------------------------------------
>
>                 Key: MYFACES-4232
>                 URL: https://issues.apache.org/jira/browse/MYFACES-4232
>             Project: MyFaces Core
>          Issue Type: Bug
>          Components: JSR-372
>    Affects Versions: 2.3.0, 2.3.1
>            Reporter: Eduardo Breijo
>            Priority: Major
>
> 1) Currently, javax.faces.component.UIWebsocket is extending 
> javax.faces.component.UIOutput. 
> According to the JSF 2.3 API it needs to extend 
> javax.faces.component.UIComponentBase
> [https://javaee.github.io/javaee-spec/javadocs/javax/faces/component/UIWebsocket.html]
>  
> I tried to made this update but it also requires an update in the 
> org.apache.myfaces.push.WebsocketComponentRenderer implementation as 
> UIComponentBase does not have the getValue() and setValue() methods.
>  
> 2) I also noticed that the following method in the auto-generated class 
> javax.faces.component.UIWebsocket from javax.faces.component._UIWebsocket is 
> missing the *<String>* in the return type.
> {code:java}
> //BEGIN CODE COPIED FROM javax.faces.component._UIWebsocket 
> public java.util.Collection getEventNames()
> {code}
> But javax.faces.component._UIWebsocket does have the <String> in the return 
> type as defined in the API:
> [https://javaee.github.io/javaee-spec/javadocs/javax/faces/component/UIWebsocket.html#getEventNames--]
>  
> It seems that myfaces-builder-plugin is not working properly in this case.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to