[
https://issues.apache.org/jira/browse/MYFACES-4234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16498431#comment-16498431
]
ASF GitHub Bot commented on MYFACES-4234:
-----------------------------------------
deki closed pull request #3: MYFACES-4234 Use intern() on FACELET_CACHE_KEY
value
URL: https://github.com/apache/myfaces/pull/3
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/api/src/main/java/javax/faces/view/facelets/FaceletContext.java
b/api/src/main/java/javax/faces/view/facelets/FaceletContext.java
index 93d4363b2..7bc54cf7a 100644
--- a/api/src/main/java/javax/faces/view/facelets/FaceletContext.java
+++ b/api/src/main/java/javax/faces/view/facelets/FaceletContext.java
@@ -40,7 +40,7 @@
public abstract class FaceletContext extends ELContext
{
// TODO: REPORT this aberration to the EG
- public static final String FACELET_CONTEXT_KEY =
"javax.faces.FACELET_CONTEXT";
+ public static final String FACELET_CONTEXT_KEY =
"javax.faces.FACELET_CONTEXT".intern();
/**
* Generate a unique ID for the passed String
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Due to spec issue 1257 we need to use intern() on FACELET_CONTEXT_KEY value
> ---------------------------------------------------------------------------
>
> Key: MYFACES-4234
> URL: https://issues.apache.org/jira/browse/MYFACES-4234
> Project: MyFaces Core
> Issue Type: Bug
> Affects Versions: 2.3.0, 2.3.1
> Reporter: Paul Nicolucci
> Assignee: Paul Nicolucci
> Priority: Minor
> Fix For: 2.3.2
>
>
> https://github.com/javaee/javaserverfaces-spec/issues/1257
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
