[
https://issues.apache.org/jira/browse/MYFACES-4239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16520400#comment-16520400
]
ASF GitHub Bot commented on MYFACES-4239:
-----------------------------------------
tandraschko edited a comment on issue #8: MYFACES-4239: Multiple performance
improvements
URL: https://github.com/apache/myfaces/pull/8#issuecomment-399456368
@pnicolucci i'm not sure about this changes out.write vs sb.append...
Why do you switchted from out.write to a new StringBuilder?
You know, this are always new object instances... And we have something like
a SharedStringBuilder
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> [perf] Additional performance improvements
> ------------------------------------------
>
> Key: MYFACES-4239
> URL: https://issues.apache.org/jira/browse/MYFACES-4239
> Project: MyFaces Core
> Issue Type: Improvement
> Components: JSR-372
> Affects Versions: 2.2.12, 2.3.1
> Reporter: Paul Nicolucci
> Assignee: Paul Nicolucci
> Priority: Minor
> Fix For: 2.2.13, 2.3.2
>
>
> Some performance improvements in :
> 1) ApplicationImpl.java
> 2) ServletExternalContextImpl.java
> 3) HtmlResponseWriterImpl.java
> 4) HTMLEncoder.java, we also discussed on the mailing list changing
> encodeURIAtributte to encodeUriAttribute to fix the typo in the method name
> so I'll do that here as well.
> 5) CDataEndEscapeFilterWriter.java
> 6) ResourceValidationUtils.java
> The following changes were made:
> - Skip calling ConcurrentHashMap.containsKey since we will call get
> afterward if containsKey == true.
> - Change to use StringBuilders instead of calling Writer.write so often.
> - Stop using Boolean for variables that don't have a null meaning. If
> null == false, then just use boolean with a default of false.
> - Don't call String.length() constantly for String variables that aren't
> re-assigned.
> - Change conditional order to avoid calling validateResourceName unless the
> other conditions are true
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
