[ https://issues.apache.org/jira/browse/MYFACES-4247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16545203#comment-16545203 ]
ASF GitHub Bot commented on MYFACES-4247: ----------------------------------------- pnicolucci commented on issue #11: MYFACES-4247: reduce number of char[] objects and CommonPropertyUtils… URL: https://github.com/apache/myfaces/pull/11#issuecomment-405247268 @tandraschko : String.toCharArray() is what is not called now The string uses its internal char[] instead of a copy to put the chars in the this.buff object. Otherwise you make a copy of the char[] with toCharArray() and then copy that char[] into this.buff This removes one copy of the char[] ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [perf] minor performance improvements in FastWriter and a couple Renderers > -------------------------------------------------------------------------- > > Key: MYFACES-4247 > URL: https://issues.apache.org/jira/browse/MYFACES-4247 > Project: MyFaces Core > Issue Type: Improvement > Components: JSR-372 > Affects Versions: 2.2.12, 2.3.1 > Reporter: Paul Nicolucci > Assignee: Paul Nicolucci > Priority: Minor > > Reduces the number of char[] objects that are created. As such, with this > change, less garbage is created and as a result there are less garbage > collections run. > In addition some minor updates to not call CommonPropertyUtils when it is not > necessary to avoid redundant method calls that cause a looking in the > attributes. -- This message was sent by Atlassian JIRA (v7.6.3#76005)