[
https://issues.apache.org/jira/browse/MYFACES-4252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16614905#comment-16614905
]
ASF GitHub Bot commented on MYFACES-4252:
-----------------------------------------
wtlucy closed pull request #20: MYFACES-4252 fix Classpath._searchDir NPE 2.1.X
URL: https://github.com/apache/myfaces/pull/20
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/impl/src/main/java/org/apache/myfaces/view/facelets/util/Classpath.java
b/impl/src/main/java/org/apache/myfaces/view/facelets/util/Classpath.java
index b2f5ee4d6..c82b1b0da 100644
--- a/impl/src/main/java/org/apache/myfaces/view/facelets/util/Classpath.java
+++ b/impl/src/main/java/org/apache/myfaces/view/facelets/util/Classpath.java
@@ -140,20 +140,23 @@ public Object run()
}
if (dirExists && dir.isDirectory())
{
- for (File file : dir.listFiles())
+ File[] dirFiles = dir.listFiles();
+ if (dirFiles != null)
{
- String path = file.getAbsolutePath();
- if (file.isDirectory())
+ for (File file : dirFiles)
{
- _searchDir(result, file, suffix);
- }
- else if (path.endsWith(suffix))
- {
- result.add(file.toURI().toURL());
+ String path = file.getAbsolutePath();
+ if (file.isDirectory())
+ {
+ _searchDir(result, file, suffix);
+ }
+ else if (path.endsWith(suffix))
+ {
+ result.add(file.toURI().toURL());
+ }
}
+ return true;
}
-
- return true;
}
return false;
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Classpath._searchDir can throw NullPointerException
> ---------------------------------------------------
>
> Key: MYFACES-4252
> URL: https://issues.apache.org/jira/browse/MYFACES-4252
> Project: MyFaces Core
> Issue Type: Bug
> Affects Versions: 2.0.24, 2.1.18, 2.2.12, 2.3.1
> Environment: WebSphere 9
> Reporter: Bill Lucy
> Assignee: Bill Lucy
> Priority: Major
>
> In rare cases, Classpath._searchDir can throw a NPE and cause startup to
> fail. I'll update _searchDir() to tolerate the case where File.listFiles()
> returns null.
> DefaultFacesC I Reading config /WEB-INF/faces-config.xml
> AbstractFaces E An error occured while initializing MyFaces:
> java.lang.NullPointerException
> javax.faces.FacesException: java.lang.NullPointerException
> ....
> Caused by: java.lang.NullPointerException
> at
> org.apache.myfaces.view.facelets.util.Classpath._searchDir(Classpath.java:143)
> at
> org.apache.myfaces.view.facelets.util.Classpath._searchResource(Classpath.java:115)
> at org.apache.myfaces.view.facelets.util.Classpath.search(Classpath.java:68)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
