henningn commented on a change in pull request #28: TOBAGO-2021: Sheet should 
be able to lazy load rows by scroll events
URL: https://github.com/apache/myfaces-tobago/pull/28#discussion_r387646316
 
 

 ##########
 File path: 
tobago-theme/tobago-theme-standard/src/main/resources/META-INF/resources/tobago/standard/tobago-bootstrap/_version/js/tobago-sheet.js
 ##########
 @@ -638,12 +840,7 @@ Tobago.Sheet.selectRange = function($sheet, $rows, first, 
last, selectDeselected
 };
 
 Tobago.Sheet.getDataIndex = function(sheet, row) {
-  var rowIndex = row.data("tobago-row-index");
-  if (rowIndex) {
-    return +rowIndex;
-  } else {
-    return row.index() + sheet.data("tobago-first");
-  }
+  return row.data("tobago-row-index")
 
 Review comment:
   missing ';'

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to