[
https://issues.apache.org/jira/browse/MYFACES-3477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17082473#comment-17082473
]
Thomas Andraschko commented on MYFACES-3477:
--------------------------------------------
I think the server-side is fine (StateCacheServerSide#serializeView):
- creates the ByteArrayOutputStream with a 1024 buffer
- wraps the outputstream with gzip (if enabled), this creates another 1024
buffer
- reads the object into the the buffer
- returns a bytearray[] copy with the real size
I think clientside (StateUtils) can be optimized, i will check this
> [perf] Review amount of byte [] arrays created during state saving
> -------------------------------------------------------------------
>
> Key: MYFACES-3477
> URL: https://issues.apache.org/jira/browse/MYFACES-3477
> Project: MyFaces Core
> Issue Type: Improvement
> Reporter: Martin Kočí
> Assignee: Leonardo Uribe
> Priority: Minor
>
> instances of byte [] are created in:
> 1) org.apache.myfaces.shared.util.StateUtils.getAsByteArray(Object,
> ExternalContext)
> 2)
> org.apache.myfaces.shared.util.serial.DefaultSerialFactory.getObjectOutputStream
> 3) writer.writeObject(object); in
> org.apache.myfaces.shared.util.StateUtils.getAsByteArray
> 4) org.apache.myfaces.shared.util.StateUtils.encode(byte[])
> 5)
> org.apache.myfaces.shared.util.serial.DefaultSerialFactory.getObjectInputStream(InputStream)
> 6) org.apache.myfaces.shared.util.StateUtils.reconstruct(String,
> ExternalContext)
> those allocations are not performance problem; only in cumulative time are
> those methods #1 source of byte [] in myfaces - maybe can be some of them
> removed.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
