[
https://issues.apache.org/jira/browse/MYFACES-3477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17082698#comment-17082698
]
Thomas Andraschko edited comment on MYFACES-3477 at 4/14/20, 8:24 AM:
----------------------------------------------------------------------
I tried to optimize it with chained stream but the performance isn't better.
I think i will close it for now. The performance is fine and implementing the
idea of Leo seems quite hard to implement.
was (Author: tandraschko):
I think ClientSide can be optimized by using chained streames (see
StateUtils#construct or #reconstruct).
I invested 2 hours and i always got other strings (compared to the current
impl) while serializing a object into a string.
Some contribution would be very welcome!
> [perf] Review amount of byte [] arrays created during state saving
> -------------------------------------------------------------------
>
> Key: MYFACES-3477
> URL: https://issues.apache.org/jira/browse/MYFACES-3477
> Project: MyFaces Core
> Issue Type: Improvement
> Reporter: Martin Kočí
> Assignee: Leonardo Uribe
> Priority: Minor
>
> instances of byte [] are created in:
> 1) org.apache.myfaces.shared.util.StateUtils.getAsByteArray(Object,
> ExternalContext)
> 2)
> org.apache.myfaces.shared.util.serial.DefaultSerialFactory.getObjectOutputStream
> 3) writer.writeObject(object); in
> org.apache.myfaces.shared.util.StateUtils.getAsByteArray
> 4) org.apache.myfaces.shared.util.StateUtils.encode(byte[])
> 5)
> org.apache.myfaces.shared.util.serial.DefaultSerialFactory.getObjectInputStream(InputStream)
> 6) org.apache.myfaces.shared.util.StateUtils.reconstruct(String,
> ExternalContext)
> those allocations are not performance problem; only in cumulative time are
> those methods #1 source of byte [] in myfaces - maybe can be some of them
> removed.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
