volosied commented on pull request #159: URL: https://github.com/apache/myfaces/pull/159#issuecomment-766374486
Sorry I didn't see your comment from the master PR. From what I read, we definitely should upgrade DES. As for HmacSHA256, I don't see any harm in updating. I found some articles about collisions with SHA1, and SHA256 seems to be generally more preferred. I'm curious about performance, but users of MyFaces always have the option to change these algorithms if they so choose. +1 from me. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
