[ https://issues.apache.org/jira/browse/MYFACES-4545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17676926#comment-17676926 ]
Thomas Andraschko edited comment on MYFACES-4545 at 1/14/23 4:16 PM: --------------------------------------------------------------------- I think we should even only check for the ProjectStage, otherwise the log is quite useless if (projectstage.dev) -> log otherwhise do nothing i would also merge it to other branches 2.3, 2.3-next, 3.0, 4.0 was (Author: tandraschko): I think we should even only check for the ProjectStage, otherwise the log is quite useless if (projectstage.dev) -> log otherwhise do nothing > BeanValidator WARNING if no value > --------------------------------- > > Key: MYFACES-4545 > URL: https://issues.apache.org/jira/browse/MYFACES-4545 > Project: MyFaces Core > Issue Type: Improvement > Components: General > Affects Versions: 2.3-next-M7, 4.0.0-RC3 > Reporter: Melloware > Priority: Major > > Currently if you have an InputTExt with no `value` the MyFaces BeanValidator > logs a WARN. > > {code:java} > ValueExpression valueExpression = > component.getValueExpression("value"); > if (valueExpression == null) > { > log.warning("cannot validate component with empty value: " > + component.getClientId(context)); > return; > } {code} > PrimeFaces always throws this when using Custom Filters that have no `value` > attribute like on the Showcase here: > [https://www.primefaces.org/showcase/ui/data/datatable/filter.xhtml] > > {code:java} > <f:facet name="filter"> > <p:selectOneMenu onchange="PF('customersTable').filter()" > styleClass="ui-custom-filter"> > <f:selectItem itemLabel="All" itemValue="#{null}" > noSelectionOption="true" /> > <f:selectItems value="#{dtFilterView.representatives}" /> > </p:selectOneMenu> > </f:facet> {code} > I wonder if we should only LOG.WAR if in JSF Stage Development but just let > it go in PRODUCTION mode -- This message was sent by Atlassian Jira (v8.20.10#820010)