[ 
https://issues.apache.org/jira/browse/MYFACES-4518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17677378#comment-17677378
 ] 

Werner Punz edited comment on MYFACES-4518 at 1/16/23 1:22 PM:
---------------------------------------------------------------

Sorry I needed to have another look, the response looks weird:

Here is the insert code:

{code:java}

@Model
public class Spec1412 {

public void addEvalScripts() {
List<String> evalScripts = 
FacesContext.getCurrentInstance().getPartialViewContext().getEvalScripts();
evalScripts.add("document.getElementById('text').innerHTML='Success!'");
evalScripts.add("document.getElementById('form:button').value='bar'");
}

}

{code}

 

Yet your response exposes following code:

{code:xml}

<eval><Unable to render embedded object: File 
([CDATA[document.getElementById('text').innerHTML='Success) not 
found.']]></eval><eval>

...

{code}

 

The test then tests for:

{code:java}

button.click();
page.waitReqJs(Duration.ofMillis(60000));
assertTrue(page.isInPage("Success!"));

{code}

 

So even if the Unable to render object file is a copy paste error:

Success) not found. is definitely not what the assert expects!

So to sum it up, not working according to the data you provided.

Works fine in 4.0 master though, just tested it.

 

!image-2023-01-16-14-20-28-972.png|width=410,height=162!


was (Author: werpu):
Sorry I needed to have another look, the response looks weird:

Here is the insert code:

{code

@Model
public class Spec1412 {

public void addEvalScripts() {
List<String> evalScripts = 
FacesContext.getCurrentInstance().getPartialViewContext().getEvalScripts();
evalScripts.add("document.getElementById('text').innerHTML='Success!'");
evalScripts.add("document.getElementById('form:button').value='bar'");
}

}

:java}

{code}

 

Yet your response exposes following code:

{code:xml}

<eval><Unable to render embedded object: File 
([CDATA[document.getElementById('text').innerHTML='Success) not 
found.']]></eval><eval>

...

{code}

 

The test then tests for:

{code:java}

button.click();
page.waitReqJs(Duration.ofMillis(60000));
assertTrue(page.isInPage("Success!"));

{code}

 

So even if the Unable to render object file is a copy paste error:

Success) not found. is definitely not what the assert expects!

So to sum it up, not working according to the data you provided.

Works fine in 4.0 master though, just tested it.

 

!image-2023-01-16-14-20-28-972.png|width=410,height=162!

> TCK Testing Issue 7: Faces 2.3 - Spec1412 Nested Composite Component does not 
> render the resources
> --------------------------------------------------------------------------------------------------
>
>                 Key: MYFACES-4518
>                 URL: https://issues.apache.org/jira/browse/MYFACES-4518
>             Project: MyFaces Core
>          Issue Type: Bug
>    Affects Versions: 2.3-next-M7, 4.0.0-RC2
>         Environment: Test Setup:
> Apache MyFaces 4.0, Typescript faces.js pull request branch:
> (https://github.com/apache/myfaces/pull/356)
> Tck Tests:
> https://github.com/werpu/tckworkbench
> (compile the 4.0 pr branch and then run the tests via maven in the workbench)
>            Reporter: Werner Punz
>            Priority: Major
>         Attachments: image-2023-01-16-14-11-36-857.png, 
> image-2023-01-16-14-20-28-972.png
>
>
> More Details:
> [https://github.com/apache/myfaces/pull/356#issuecomment-1338988239]
>  
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to