[ 
https://issues.apache.org/jira/browse/MYFACES-4533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17678526#comment-17678526
 ] 

Werner Punz edited comment on MYFACES-4533 at 1/19/23 7:52 AM:
---------------------------------------------------------------

 

I checked a mojarra site running on 2.3, there they have a viewContainerId in 
the id of the viewstate but the name is still jakarta.faces.ViewState which is 
our current behavior.

!image-2023-01-19-08-44-48-874.png!

Maybe they changed it in 4.0, I am atm a little bit puzzled, let me check what 
the TCK on mojarra exposes for this case.

 


was (Author: werpu):
 

I checked a mojarra site running on 2.3, there they have a viewContainerId in 
the id of the viewstate but the name is still jakarta.faces.ViewState which is 
our current behavior.

!image-2023-01-19-08-44-48-874.png!

Maybe they changed it in 4.0, I am atm a little bit puzzled, let me check what 
the TCK on mojarra exposes for this case.

On the master branch ist is:

!image-2023-01-19-08-48-12-961.png|width=903,height=642!

So our current code, targetting, the id only for the prefixing works. I will 
test the old code again whether 790 fails somewhere.

 

 

 

> TCK: Spec 790:  Viewstate input element's name attribute should be prefixed 
> with naming container id 
> -----------------------------------------------------------------------------------------------------
>
>                 Key: MYFACES-4533
>                 URL: https://issues.apache.org/jira/browse/MYFACES-4533
>             Project: MyFaces Core
>          Issue Type: Bug
>    Affects Versions: 4.0.0-RC2
>            Reporter: Volodymyr Siedlecki
>            Assignee: Werner Punz
>            Priority: Major
>         Attachments: image-2023-01-19-08-44-48-874.png, 
> image-2023-01-19-08-48-12-961.png, namespacedView.war
>
>
> Failing Line: 
> https://github.com/jakartaee/faces/blob/master/tck/faces23/namespacedView/src/test/java/ee/jakarta/tck/faces/test/javaee8/namespacedView/Spec790WithNamespacedViewIT.java#L15
>  5
> Generated Viewstate: 
> {code:java}
> <input type="hidden" name="jakarta.faces.ViewState" 
> id="j_id__v_0:jakarta.faces.ViewState:1" 
> value="NzVhMDlkOGYwNjY1ZWZkODAwMDAwMDAy" autocomplete="off">
> {code}
> The test expects the name attribute to be prefixed with `j_id__v_0`.  My 
> understanding is this should only apply when the view root is an instance of 
> a NamingContainer.   
> The test app's faces-config has the following configuration: 
> https://github.com/jakartaee/faces/blob/master/tck/faces23/namespacedView/src/main/webapp/WEB-INF/faces-config.xml#L25-L28



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to