volosied commented on code in PR #492:
URL: https://github.com/apache/myfaces/pull/492#discussion_r1082867841


##########
api/src/main/java/jakarta/faces/component/UISelectOne.java:
##########
@@ -69,19 +69,20 @@ public String getFamily()
     }
 
     /**
-     * Verify that when ever there is a ValueExpression and submitted value is 
not empty, then
+     * Check whether a group exists and then
      * visit all the UISelectItem elements within the UISelectOne radio 
components to check if
-     * the submitted value exists in any of the select items.
+     * the submitted value is empty (ie. not submitted) or if a previous group 
item has been
+     * has failed to be validated (if no so further validation processing is 
needed)
      *
      * @see 
jakarta.faces.component.UIInput#processValidators(jakarta.faces.context.FacesContext)
      */
     @Override
     public void processValidators(FacesContext context) 
     {
         String group = getGroup();
-        ValueExpression ve = getValueExpression("value");

Review Comment:
   ValueExpression was removed because not all scenario uses a VE in the TCK 
test, i.e: 
   ` <h:selectOneRadio id="radio2" group="foo" required="true" 
requiredMessage="required2" />`  



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to