[
https://issues.apache.org/jira/browse/MYFACES-4533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17679785#comment-17679785
]
Werner Punz edited comment on MYFACES-4533 at 1/24/23 7:53 AM:
---------------------------------------------------------------
Hi... the double request parameter is now fixed in my special branch.
However I tried to enable the navigation by adding the prefixes in the rest of
the ResponseStateManager,
but it is not working yet. My assumption is that when the initial state might
be created the naming container prefix is not yet present, but that is just a
hunch from my side.
I am not so deep into the impl to really know what the root cause could be, it
definitely has to do with the ViewState though.
[https://gist.github.com/werpu/4844714e8c3d416ad8e57607be1eb376]
Here is the code for the update state manager
I will give up patching the server code for now, and will start to provide a
patch for the old client side codebase from tomorrow onwards, so that we get
the TCK 790 client fixes in.
If someone is willing to take over the server to get this sorted out, feel free
to continue.
[~volosied] [~tandraschko] maybe one of you?
Also I have to clear things up, per spec the params assoc array is the request
pass through params: But I am not sure whether they need to be prefixed as
well, does not really make sense but per spec they might have to be. Because
those are end user params I would rather not do it. I tried to push params
through Mojarra that way, and they got filtered out, a bug I assume.
was (Author: werpu):
Hi... the double request parameter is now fixed in my special branch.
However I tried to enable the navigation by adding the prefixes in the rest of
the ResponseStateManager,
but it is not working yet. My assumption is that when the initial state might
be created the naming container prefix is not yet present, but that is just a
hunch from my side.
I am not so deep into the impl to really know what the root cause could be, it
definitely has to do with the ViewState though.
[https://gist.github.com/werpu/4844714e8c3d416ad8e57607be1eb376]
Here is the code for the update state manager
I will give up patching the server code for now, and will start to provide a
patch for the old client side codebase from tomorrow onwards, so that we get
the TCK 790 client fixes in.
If someone is willing to take over the server to get this sorted out, feel free
to continue.
> TCK: Spec 790: Viewstate input element's name attribute should be prefixed
> with naming container id
> -----------------------------------------------------------------------------------------------------
>
> Key: MYFACES-4533
> URL: https://issues.apache.org/jira/browse/MYFACES-4533
> Project: MyFaces Core
> Issue Type: Bug
> Affects Versions: 4.0.0-RC2
> Reporter: Volodymyr Siedlecki
> Assignee: Werner Punz
> Priority: Major
> Attachments: image-2023-01-19-08-44-48-874.png,
> image-2023-01-19-08-48-12-961.png, namespacedView.war
>
>
> Failing Line:
> https://github.com/jakartaee/faces/blob/master/tck/faces23/namespacedView/src/test/java/ee/jakarta/tck/faces/test/javaee8/namespacedView/Spec790WithNamespacedViewIT.java#L15
> 5
> Generated Viewstate:
> {code:java}
> <input type="hidden" name="jakarta.faces.ViewState"
> id="j_id__v_0:jakarta.faces.ViewState:1"
> value="NzVhMDlkOGYwNjY1ZWZkODAwMDAwMDAy" autocomplete="off">
> {code}
> The test expects the name attribute to be prefixed with `j_id__v_0`. My
> understanding is this should only apply when the view root is an instance of
> a NamingContainer.
> The test app's faces-config has the following configuration:
> https://github.com/jakartaee/faces/blob/master/tck/faces23/namespacedView/src/main/webapp/WEB-INF/faces-config.xml#L25-L28
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
