[
https://issues.apache.org/jira/browse/MYFACES-4610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17737688#comment-17737688
]
Werner Punz edited comment on MYFACES-4610 at 6/27/23 2:32 PM:
---------------------------------------------------------------
The issue here is indeed the fix we added recently that a key value pair of the
issuing element is added.
The problem here is that the issuing element has the same id (the virtual
element tobago-select-many-checkbox but has no value, to make matters worse the
embedded real inputs have the same name as the input elements id:
<tobago-select-many-checkbox id="page:numbers"...
<input type="checkbox" name="page:numbers"
So what happes is that i select the value of the tobago-select-many-checkbox
and pass a null which overwrites whatever is sent under the name page:numbers
the possible fix probably simply is to check whether the issuing identifier is
some kind of value holder and if not then omit it simply.
Another solution would be to check wether any element under the name of issuing
element.id is present but the first solution probably would be simpler and
would work for the usecase of the user)
This was a specialy case anyway required by one user to allow easier
idenitification and is not per se designed as is by the spec to mimick old
behavior which we had in earlier implementations.
was (Author: werpu):
The issue here is indeed the fix we added recently that a key value pair of the
issuing element is added.
The problem here is that the issuing element has the same id (the virtual
element tobago-select-many-checkbox but has no value, to make matters worse the
embedded real inputs have the same name as the input elements id:
<tobago-select-many-checkbox id="page:numbers"...
<input type="checkbox" name="page:numbers"
So what happes is that i select the value of the tobago-select-many-checkbox
and pass a null which overwrites whatever is sent under the name page:numbers
the possible fix probably simply is to check whether the issuing identifier is
some kind of value holder and if not then omit it simply.
This was a specialy case anyway required by one user to allow easier
idenitification and is not per se designed as is by the spec.
> Fix for issuing element key:value combination breaks Tobago
> -----------------------------------------------------------
>
> Key: MYFACES-4610
> URL: https://issues.apache.org/jira/browse/MYFACES-4610
> Project: MyFaces Core
> Issue Type: Bug
> Affects Versions: 3.0.2, 2.3-next-M8, 4.0.2
> Reporter: Werner Punz
> Assignee: Werner Punz
> Priority: Major
>
> This is a follow up issue caused by the fix for
> https://issues.apache.org/jira/browse/MYFACES-4606
> raised by the Tobago guys.
> The fix broke one of their testcases!
> [https://github.com/henningn/myfaces-tobago.git]
> 4 checkboxes on the page, example does not work anymore because
> * git checkout jsfjs_next_gen402
> * mvn clean install
> * cd tobago-example/tobago-example-demo
> * mvn clean -Pdev -Pjetty jetty:run
> * open
> [http://localhost:8080/content/030-select/50-selectManyCheckbox/Multi_Checkbox.xhtml]
> The request adds the issuing element with a null value!
>
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
