melloware commented on PR #605: URL: https://github.com/apache/myfaces/pull/605#issuecomment-1654057723
Also these tests are failing and want to make sure they are correctly failing before I fix them? ``` Error: Errors: Error: UIRepeatTest.testSaveAndRestorePortletLifecycleWithoutPss1:119 » LocationAwareFaces when 'value' attribute is set, you need 'offset' attribute instead of 'begin' attribute Error: AcidARCacheELMyFacesRequestTestCase>AcidMyFacesRequestTestCase.testUIRepeatCC1:2183->AbstractMyFacesRequestTestCase.processLifecycleExecuteAndRender:225->AbstractMyFacesRequestTestCase.renderResponse:256->AbstractMyFacesTestCase.renderResponse:551 » LocationAwareFaces when 'value' attribute is set, you need 'offset' attribute instead of 'begin' attribute Error: AcidMyFacesRequestTestCase.testUIRepeatCC1:2183->AbstractMyFacesRequestTestCase.processLifecycleExecuteAndRender:225->AbstractMyFacesRequestTestCase.renderResponse:256->AbstractMyFacesTestCase.renderResponse:551 » LocationAwareFaces when 'value' attribute is set, you need 'offset' attribute instead of 'begin' attribute Error: AcidNoPssMyFacesRequestTestCase>AcidMyFacesRequestTestCase.testUIRepeatCC1:2183->AbstractMyFacesRequestTestCase.processLifecycleExecuteAndRender:225->AbstractMyFacesRequestTestCase.renderResponse:256->AbstractMyFacesTestCase.renderResponse:551 » LocationAwareFaces when 'value' attribute is set, you need 'offset' attribute instead of 'begin' attribute Error: AcidPssRefreshMyFacesRequestTestCase>AcidMyFacesRequestTestCase.testUIRepeatCC1:2183->AbstractMyFacesRequestTestCase.processLifecycleExecuteAndRender:225->AbstractMyFacesRequestTestCase.renderResponse:256->AbstractMyFacesTestCase.renderResponse:551 » LocationAwareFaces when 'value' attribute is set, you need 'offset' attribute instead of 'begin' attribute Error: AcidPssRefreshPreserveStateMyFacesRequestTestCase>AcidMyFacesRequestTestCase.testUIRepeatCC1:2183->AbstractMyFacesRequestTestCase.processLifecycleExecuteAndRender:225->AbstractMyFacesRequestTestCase.renderResponse:256->AbstractMyFacesTestCase.renderResponse:551 » LocationAwareFaces when 'value' attribute is set, you need 'offset' attribute instead of 'begin' attribute Error: RepeatTestCase.testInvokeOnComponent:133 » LocationAwareFaces when 'value' attribute is set, you need 'offset' attribute instead of 'begin' attribute Error: RepeatTestCase.testInvokeOnComponentBeginEnd:822 » LocationAwareFaces when 'value' attribute is not set, you need 'begin' attribute instead of 'offset' attribute Error: RepeatTestCase.testInvokeOnEmptyList:879 » LocationAwareFaces when 'value' attribute is set, you need 'offset' attribute instead of 'begin' attribute Error: RepeatTestCase.testInvokeOnNullModel:853 » LocationAwareFaces when 'value' attribute is not set, you need 'begin' attribute instead of 'offset' attribute Error: RepeatTestCase.testRepeat:70 » LocationAwareFaces when 'value' attribute is set, you need 'offset' attribute instead of 'begin' attribute Error: RepeatTestCase.testRepeatOffset:364 » LocationAwareFaces when 'value' attribute is set, you need 'offset' attribute instead of 'begin' attribute Error: RepeatTestCase.testRepeatOffset2:783 » LocationAwareFaces when 'value' attribute is set, you need 'offset' attribute instead of 'begin' attribute Error: RepeatTestCase.testRepeatOffset_0:398 » LocationAwareFaces when 'value' attribute is set, you need 'offset' attribute instead of 'begin' attribute Error: RepeatTestCase.testRepeatOffset_0_7:457 » LocationAwareFaces when 'value' attribute is set, you need 'offset' attribute instead of 'begin' attribute Error: RepeatTestCase.testRepeatOffset_1:587 » LocationAwareFaces when 'value' attribute is set, you need 'offset' attribute instead of 'begin' attribute Error: RepeatTestCase.testRepeatOffset_1_7:653 » LocationAwareFaces when 'value' attribute is set, you need 'offset' attribute instead of 'begin' attribute Error: RepeatTestCase.testVisitTree:267 » LocationAwareFaces when 'value' attribute is set, you need 'offset' attribute instead of 'begin' attribute ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org