[ https://issues.apache.org/jira/browse/MYFACES-4536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17771486#comment-17771486 ]
Melloware commented on MYFACES-4536: ------------------------------------ Thanks for your help! Got to the bottom of it! See my PR and I think all our integration tests are passing again! [https://github.com/primefaces/primefaces/pull/10759] Basically had to get rid of our Wrapper as it was not doing anything and extend PartialResponseWriter directly. Then I had to make our CSPPartial extend our PrimePartial so `endDocument` was called correctly. > PartialResponseWriter: Do no wrap the writer > -------------------------------------------- > > Key: MYFACES-4536 > URL: https://issues.apache.org/jira/browse/MYFACES-4536 > Project: MyFaces Core > Issue Type: Improvement > Components: General > Affects Versions: 2.2.14, 2.3.10, 2.3-next-M7, 4.0.0-RC2 > Reporter: Melloware > Assignee: Werner Punz > Priority: Major > Attachments: csp-results.zip, image-2023-10-02-20-33-05-162.png, > mojarra-csp-new.txt > > > Per BalusC: > Since JSF 2.3 the default constructor of {{FacesWrapper}} subclasses has been > deprecated in order to force implementors to instead use the constructor > taking the wrapped instance (and to raise their awareness), so that logically > the inherited {{getWrapped()}} method will be used throughout the > implementation instead of the local {{wrapped}} variable. This will ensure > that the correct implementation is returned and correct behavior is performed > might the {{FacesWrapper}} implementation itself being wrapped by yet another > {{FacesWrapper}} implementation further down the chain. Because, when the > {{FacesWrapper}} implementation incorrectly/accidentally uses the local > {{wrapped}} variable instead of the {{getWrapped()}} method, then that other > {{FacesWrapper}} implementation will basically be completely ignored, hereby > breaking the decorator pattern. > > PrimeFaces ticket: https://github.com/primefaces/primefaces/issues/9518 -- This message was sent by Atlassian Jira (v8.20.10#820010)