Re: [PR] MYFACES-4606 Follow up: do not send values for unselected radio / checkbox elements [myfaces]

[via GitHub]

volosied commented on PR #634:
URL: https://github.com/apache/myfaces/pull/634#issuecomment-1777937812

   If I removed the code to just 
   ```
       appendIssuingItem: function (item, targetBuf) {
           // if triggered by a Button send it along
           if (item && item.type) {
   
               // do not append if unselected
               if ((item.type == "checkbox" || item.type == "radio") 
                && !item.checked) {
                   return;
               }
               
               //buttons not always have a name unlike inputs
               targetBuf.append(item.id || item.name, item.value);
           }
       },
   ```
   
   then I see the form sent as an array.
   ![Screenshot 2023-10-24 at 3 53 59 
PM](https://github.com/apache/myfaces/assets/5934310/ba004ecc-7ce9-4462-8fd5-ea573b29c0cc)
   Looks like it's caused by the preprocessed data also containing the issuing 
element? 
   
   ![Screenshot 2023-10-24 at 3 54 33 
PM](https://github.com/apache/myfaces/assets/5934310/ac3397a5-ff60-48e2-b411-a636345209bb)
   
   
   Otherwise, with the existing checks, only true is sent: 
   
       
   ![Screenshot 2023-10-24 at 3 50 50 
PM](https://github.com/apache/myfaces/assets/5934310/6a9876b8-7c30-4ac6-9d1e-e6e361e2e10f)
   
       


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org