melloware commented on code in PR #730:
URL: https://github.com/apache/myfaces/pull/730#discussion_r1686498845


##########
impl/src/main/java/org/apache/myfaces/context/servlet/PartialViewContextImpl.java:
##########
@@ -579,6 +579,11 @@ public VisitResult visit(VisitContext context, UIComponent 
target)
             {
                 ((EditableValueHolder)target).resetValue();
             }
+            else if (!VisitContext.ALL_IDS.equals(context.getIdsToVisit()))
+            {
+                // Render ID didn't specifically point an EditableValueHolder. 
Visit all children as well.
+                
target.visitTree(VisitContext.createVisitContext(FacesContext.getCurrentInstance(),
 null, context.getHints()), this);

Review Comment:
   i saw that about the FacesContext but was trying not to make the change too 
invasive. I will rework this today.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to