+1 across the board. Voting is now closed, and I'll get it released. Thanks everyone! :)
Volodymyr On 2024/12/06 14:30:45 Volodymyr Siedlecki wrote: > TCK results are good. > > +1 from me as well. > > On 2024/12/04 15:08:11 Melloware Inc wrote: > > No objections from me... > > > > On Wed, Dec 4, 2024 at 10:07 AM Volodymyr Siedlecki <[email protected]> > > wrote: > > > > > One thing I should mention: I noticed a difference in the generated > > > META-INF/myfaces-metadata.xml > > > > > > Before (RC3): > > > <interface name="jakarta.faces.component.ActionSource"/> > > > > > > After (4.1.0): > > > <interface name="ActionSource"/> > > > > > > This missing package prefix difference is caused by the exclusion of the > > > ActionSource class in the myfaces-plugin-builder (PR #800). I don't think > > > this file is used anywhere, but I wanted to get some input. > > > > > > Can we continue with the 4.1.0 release and look to fix is in 4.1.1, if no > > > one has any objections? > > > > > > Thanks, > > > > > > Volodymyr > > > > > > On 2024/12/04 14:43:03 Paul Nicolucci wrote: > > > > +1 > > > > > > > > Thanks, > > > > > > > > Paul Nicolucci > > > > > > > > On Wed, Dec 4, 2024 at 7:47 AM Thomas Andraschko < > > > > [email protected]> wrote: > > > > > > > > > +1 > > > > > > > > > > Am Mi., 4. Dez. 2024 um 13:26 Uhr schrieb Melloware Inc < > > > > > [email protected]>: > > > > > > > > > >> +1 > > > > >> > > > > >> On Wed, Dec 4, 2024 at 4:56 AM Werner Punz <[email protected]> > > > wrote: > > > > >> > > > > >>> +1 > > > > >>> > > > > >>> Werner > > > > >>> > > > > >>> Am Mi., 4. Dez. 2024 um 05:11 Uhr schrieb Volodymyr Siedlecki < > > > > >>> [email protected]>: > > > > >>> > > > > >>>> Hi, > > > > >>>> > > > > >>>> I was running the needed tasks to get the 4.1.0 release of Apache > > > > >>>> MyFaces core out. > > > > >>>> > > > > >>>> Please note that this vote concerns all of the following parts: > > > > >>>> 1. Maven artifact group “org.apache.myfaces.core” v4.1.0 [1] > > > > >>>> > > > > >>>> The artifacts were deployed on nexus repo [1] for binary and source > > > > >>>> packages. > > > > >>>> > > > > >>>> The release notes could be found at [4]. > > > > >>>> > > > > >>>> The japicmp tool shows 2 binary incompatibilities with 4.1.0-RC3: > > > > >>>> - ActionSource and ActionSource2 classes (MYFACES-4692) > > > > >>>> Please take a look at the attached results.html. > > > > >>>> > > > > >>>> I tested the snapshot against the TCK and it passed. I will rerun > > > the > > > > >>>> tests again this release to confirm again. > > > > >>>> > > > > >>>> Please take a look at the “4.1.0" artifacts and vote! (see [3]) > > > > >>>> > > > > >>>> Please note: This vote is “majority approval” with a minimum of > > > three +1 > > > > >>>> votes (see [2]). > > > > >>>> > > > > >>>> ------------------------------------------------ > > > > >>>> [ ] +1 for community members who have reviewed the bits > > > > >>>> [ ] +0 > > > > >>>> [ ] -1 for fatal flaws that should cause these bits not to be > > > released, > > > > >>>> and > > > > >>>> why. > > > > >>>> ------------------------------------------------ > > > > >>>> > > > > >>>> Thanks, > > > > >>>> > > > > >>>> Volodymyr > > > > >>>> > > > > >>>> [1] > > > > >>>> > > > https://repository.apache.org/content/repositories/orgapachemyfaces-1255/org/apache/myfaces/core/ > > > > >>>> [2] http://www.apache.org/foundation/voting.html#ReleaseVotes > > > > >>>> [3] > > > > >>>> > > > https://repository.apache.org/content/repositories/orgapachemyfaces-1255/org/apache/myfaces/core/myfaces-core-assembly/ > > > > >>>> [4] > > > > >>>> > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=10600&version=12355246 > > > > >>>> > > > > >>> > > > > >> > > > > >> -- > > > > >> ============================== > > > > >> Melloware > > > > >> [email protected] > > > > >> http://melloware.com > > > > >> ============================== > > > > >> > > > > > > > > > > > > > > > > > > -- > > ============================== > > Melloware > > [email protected] > > http://melloware.com > > ============================== > > >
