lofwyr14 commented on code in PR #5805:
URL: https://github.com/apache/myfaces-tobago/pull/5805#discussion_r1885073382
##########
tobago-core/src/main/java/org/apache/myfaces/tobago/internal/renderkit/renderer/SheetRenderer.java:
##########
@@ -600,17 +606,7 @@ private void encodeTableBody(
// todo like in TreeListboxRenderer
writer.writeAttribute(DataAttributes.TREE_PARENT, parentId, false);
}
-
- AbstractUIRow row = null;
- for (final UIColumn column : columns) {
- if (column.isRendered()) {
- if (column instanceof AbstractUIRow) {
- row = (AbstractUIRow) column;
- // todo: Markup.CLICKABLE ???
- }
- }
- }
- // the row client id depends from the existence of an UIRow component!
TBD: is this good?
+ // the row client id depends on from the existence of an UIRow
component! TBD: is this good?
Review Comment:
The client ID of a row depends on the presence of a UIRow component. TBD: is
this good?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
