henningn commented on code in PR #6001:
URL: https://github.com/apache/myfaces-tobago/pull/6001#discussion_r1950691902
##########
tobago-theme/tobago-theme-charlotteville/src/main/scss/_custom.scss:
##########
@@ -152,6 +191,16 @@ tobago-form {
color: #333333;
}
+// Textarea
+textarea:not([readonly]):not([disabled]) {
+ color: #666666;
Review Comment:
inputfield, textarea and date have the same text color. The color should not
be set for every component by itself.
Either use the SCSS syntax, for example:
```
.form-control[type="text"], .form-control[type="date"], textarea {
&:not([readonly]):not([disabled]) {
color: #666666
}
}
```
or use a variable (e. g. $form-control-text-color: #666666), or have a look
at the Bootstrap variables. I'm not sure but the $input-color variable might be
the one.
##########
tobago-example/tobago-example-demo/src/main/webapp/menu.xhtml:
##########
@@ -115,7 +115,8 @@
<tc:link
outcome="/content/000-intro/96-logging-info/Logging_Info.xhtml"
immediate="true" label="Logging Info"
disabled="#{! serverInfo.enabled}"/>
<tc:separator/>
- <tc:link link="http://myfaces.apache.org/tobago"; label="Tobago
Home"/>
+ <tc:link link="https://myfaces.apache.org/#/tobago"; label="Tobago
Project" image="bi-box-arrow-up-right"/>
Review Comment:
Please use target="_blank" for links that should open a new browser tab.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
