I am still stumped as to why Mojarra passes this test? We can revert the code but then Thomas I need to put the Hack into PrimeFaces ExceptionHandler?
On Tue, Mar 18, 2025 at 10:21 PM Volodymyr Siedlecki <[email protected]> wrote: > -1 > > The TCK did not actually run because I specified the wrong branch in the > build. I'm sorry. > > If it did run, it would have failed against this test: > > https://github.com/jakartaee/faces/blob/4.1.2-RELEASE/tck/old-tck/source/src/com/sun/ts/tests/jsf/api/jakarta_faces/render/renderkit/TestServlet.java#L290 > > It's expecting an IllegalArgumentException, but it's no longer thrown. > > https://issues.apache.org/jira/browse/MYFACES-4703 > > Either we challenge this test, revert the change, and create a new fix. > > On 2025/03/19 01:33:35 Volodymyr Siedlecki wrote: > > Hi, > > > > I was running the needed tasks to get the 4.0.3 release of Apache MyFaces > > core out. > > > > Please note that this vote concerns all of the following parts: > > 1. Maven artifact group "org.apache.myfaces.core" v4.0.3 [1] > > > > The artifacts were deployed on nexus repo [1] for binary and source > > packages. > > > > The release notes could be found at [4]. > > > > The japicmp tool shows only non-spec binary incompatibilities with the > > 4.0.3 API jar when compared to the previous 4.0.2 jar These differences > are > > in the org.apache.myfaces.core.api.shared package. Please take a look at > > the attached results html file. > > > > > > A recent snapshot was tested against the TCK and passed. I will run it > > again to verify it again once more before releasing the jars. > > > > Please take a look at the "4.0.3" artifacts and vote! (see [3]) > > > > Please note: This vote is "majority approval" with a minimum of three +1 > > votes (see [2]). > > > > ------------------------------------------------ > > [ ] +1 for community members who have reviewed the bits > > [ ] +0 > > [ ] -1 for fatal flaws that should cause these bits not to be released, > and > > why. > > ------------------------------------------------ > > > > Thanks, > > > > Volodymyr > > > > [1] > > > https://repository.apache.org/content/repositories/orgapachemyfaces-1261/org/apache/myfaces/core/ > > [2] http://www.apache.org/foundation/voting.html#ReleaseVotes > > [3] > > > https://repository.apache.org/content/repositories/orgapachemyfaces-1261/org/apache/myfaces/core/myfaces-core-assembly/ > > [4] > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=10600&version=12354227 > > > -- ============================== Melloware [email protected] http://melloware.com ==============================
