[ 
https://issues.apache.org/jira/browse/MYFACES-4720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17985849#comment-17985849
 ] 

Werner Punz edited comment on MYFACES-4720 at 6/24/25 12:20 PM:
----------------------------------------------------------------

Btw we probably never triggered the issue anyway, because the remapping code in 
myfaces as far as I can see in the new codebase only triggers as I said before, 
if no protocol string is delivered from outside, so the code we will break 
probably will be minimal!

I cannot speak for the old codebase, but I guess the same, since I ported the 
code as is over mostly!

I will then simply remove the affected parts in the new and old codebas later 
tonight!

 


was (Author: werpu):
Btw we probably never triggered the issue anyway, because the remapping code in 
myfaces as far as I can see in the new codebase only triggers as I said before, 
if no protocol string is delivered from outside, so the code we will break 
probably will be minimal!

I cannot speak for the old codebase, but I guess the same, since I ported the 
code as is over mostly!

 

> WebSocket secure protocol
> -------------------------
>
>                 Key: MYFACES-4720
>                 URL: https://issues.apache.org/jira/browse/MYFACES-4720
>             Project: MyFaces Core
>          Issue Type: Bug
>          Components: General
>    Affects Versions: 4.0.3, 4.1.1
>            Reporter: Melloware
>            Assignee: Werner Punz
>            Priority: Major
>
> [~werpu] this was reported at Mojarra: 
> https://github.com/eclipse-ee4j/mojarra/issues/5578
> I believe MyFaces has the same issue in PushImpl.ts found here
> {code:javascript}
> export module PushImpl {
>     const URL_PROTOCOL = DQ.global().location.protocol.replace("http", "ws") 
> + "//";
> {code}
> What are your thoughts?



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to