[ 
https://issues.apache.org/jira/browse/MYFACES-4736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18083417#comment-18083417
 ] 

Werner Punz edited comment on MYFACES-4736 at 5/26/26 6:56 AM:
---------------------------------------------------------------

Checked it: The link is misleading: 
[https://developer.mozilla.org/de/docs/Web/JavaScript/Reference/Global_Objects/Object/assign]
 points to a description of generic Object.assign, which is part of the 
EcmaScript specification but only for 27 but widely supported by literally all 
browsers by now! The polyfill code is derived from the example provided as 
fallback or the spec requirements, it differs strongly as in structure and api 
usage, by utilizing modern apis for arrays and also how the attributes are 
handled!

I will simply remove the marker, this is fix enough, given the code itself is 
clear!

 


was (Author: werpu):
Checked it: The link is misleading: 
[https://developer.mozilla.org/de/docs/Web/JavaScript/Reference/Global_Objects/Object/assign]
 points to a description of generic Object.assign, which is part of the 
EcmaScript specification but only for 27 but widely supported by literally all 
browsers by now! The polyfill code is derived from the example provided as 
fallback, but not the same utilizing the same ideas for the fallback (there are 
not that many ways to implement this) but modernized in their api usage!

I will simply remove the marker, this is fix enough, given the code itself is 
clear!

 

> Replace/remove javascript functions with share-alike license
> ------------------------------------------------------------
>
>                 Key: MYFACES-4736
>                 URL: https://issues.apache.org/jira/browse/MYFACES-4736
>             Project: MyFaces Core
>          Issue Type: Improvement
>          Components: General
>    Affects Versions: 4.1.2
>            Reporter: Florian Schwarz
>            Assignee: Werner Punz
>            Priority: Major
>             Fix For: 5.0.0, 4.0.4, 4.1.3
>
>
> Some javascript function, e.g. _mozMatchesSelector in 
> /META-INF/resources/jakarta.faces/faces-development.js, line 7152, contain a 
> comment 
> {code:java}
> // source: https:// developer.mozilla.org/en-US/docs/Web/API/Element/matches
> // code snippet license: https:// creativecommons.org/licenses/by-sa/2.5/ 
> {code}
> From my understanding, this by-sa (share-alike) means, that if one uses 
> myfaces in its project, one has to use also the CC-BY-SA-2.5 license for his 
> project ([https://creativecommons.org/licenses/by-sa/2.5/deed.en] ). So I 
> wanted to ask if it would be possible to replace  or remove those functions, 
> allowing users of myfaces to use a different license.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to