Hi, +1 (binding) There some minor license issues that can be fix next release
I checked: - LICENSE changes look good, a couple of minor issues (see below) - NOTICE files fine - one binary file in mynewt manager [1] - I don’t 100% sure this is compiled code but you may want to consider removing it - all needed source file have ASF headers - can compile from source In the core LICENSE you mention MQTT as being under a EPL 1.0 license. That’s category B and can’t be included in an Apache source distribution, it is however actually under EDL which is Category A and can be included. The correct license in full is included so please fix the typo in the LICENSE for the next release. In the mynewt manger: - In LICENSE structs is mentioned twice I add the send one should be another product name given the link? - the crypto libraries also include code based on public domain code e.g. [2] you may want to add this to license. There’s about a dozen instances from a couple of different sources. - Missing BSD license for pkg errors [3] and these file licensed by apple [4] and this [5] note the terms of the license [6] Thanks, Justin 1. apache-mynewt-newtmgr-1.3.0/vendor/golang.org/x/crypto/ed25519/testdata/sign.input.gz 2. apache-mynewt-newtmgr-1.3.0/vendor/golang.org/x/crypto/curve25519/const_amd64.h 3. apache-mynewt-newtmgr-1.3.0/vendor/github.com/pkg/errors/LICENSE 4. apache-mynewt-newtmgr-1.3.0/vendor/golang.org/x/net/html/testdata/webkit/ 5. apache-mynewt-newtmgr-1.3.0/vendor/golang.org/x/net/html/charset/testdata/README 6. https://www.w3.org/Consortium/Legal/2008/04-testsuite-license
