Hi Frank, It’s all good. Thanks for the PR.
> On 16 Oct 2019, at 23.08, Frank <myn...@hackdaworld.org> wrote: > > Hi all, > > following Marko's advice, I just created a PR > > https://github.com/apache/mynewt-core/pull/2047 > > to remove the SUCCESS and FAIL #define statements in > net/lora/node/include/node/utilities.h. They are not used within the > (Semtech) net/lora code, however, they conflict with the CMSIS ErrorStatus > enum type definitions of several STM32 MCUs. > > Example: > > Error: In file included from > repos/apache-mynewt-core/net/lora/node/include/node/mac/LoRaMac.h:52:0, > from > repos/apache-mynewt-core/net/lora/node/src/mac/region/Region.c:31: > repos/apache-mynewt-core/net/lora/node/include/node/utilities.h:35:53: error: > expected identifier before numeric constant > #define SUCCESS 1 > ^ > repos/apache-mynewt-core/hw/mcu/stm/stm32f0xx/src/ext/Drivers/CMSIS/Device/ST/STM32F0xx/Include/stm32f0xx.h:191:3: > note: in expansion of macro 'SUCCESS' > SUCCESS = !ERROR > ^~~~~~~ > > However, I am not sure, whether this is the way to do it. > > Best, > Frank
