Seems fine to me.
> On Apr 6, 2016, at 1:45 PM, Vipul Rahane <vi...@runtime.io> wrote: > > Hello, > > Current definition: void hal_gpio_toggle() doesn’t return anything. > Proposed definition: int hal_gpio_toggle(). I want to do this so that it > returns the pins changed state. I would like to make this change so that we > know what the gpio is actually set to. > > Both ways we do hal_gpio_read(). Thoughts ? > > Regards, > Vipul Rahane