sanha commented on a change in pull request #1: [NEMO-26] Implement SourceLocationAwareSchedulingPolicy URL: https://github.com/apache/incubator-nemo/pull/1#discussion_r172726862
########## File path: runtime/master/src/main/java/edu/snu/nemo/runtime/master/scheduler/BatchSingleJobScheduler.java ########## @@ -321,7 +192,13 @@ public synchronized void onExecutorRemoved(final String executorId) { } } - private synchronized void scheduleRootStages() { + @Override + public void terminate() { + this.schedulerRunner.terminate(); + this.pendingTaskGroupQueue.close(); + } + + private void scheduleRootStages() { Review comment: Please add comment. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services