seojangho commented on a change in pull request #1: [NEMO-26] Implement
SourceLocationAwareSchedulingPolicy
URL: https://github.com/apache/incubator-nemo/pull/1#discussion_r172755006
##########
File path:
runtime/master/src/main/java/edu/snu/nemo/runtime/master/RuntimeMaster.java
##########
@@ -91,21 +87,17 @@
@Inject
public RuntimeMaster(final Scheduler scheduler,
- final SchedulerRunner schedulerRunner,
- final PendingTaskGroupQueue pendingTaskGroupQueue,
final ContainerManager containerManager,
final BlockManagerMaster blockManagerMaster,
final MetricMessageHandler metricMessageHandler,
final MessageEnvironment masterMessageEnvironment,
@Parameter(JobConf.DAGDirectory.class) final String
dagDirectory) {
- // We would like to keep the master event thread pool single threaded
+ // We would like to use a single thread for runtime master operations
// since the processing logic in master takes a very short amount of time
// compared to the job completion times of executed jobs
// and keeping it single threaded removes the complexity of multi-thread
synchronization.
- this.masterControlEventExecutor = Executors.newSingleThreadExecutor();
+ this.runtimeMasterThread = Executors.newSingleThreadExecutor();
Review comment:
It's always good idea to name threads. Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
