sanha commented on a change in pull request #11: [NEMO-42] Make SchedulerRunner
reactive, Ensure reverse-topological ordering in scheduling
URL: https://github.com/apache/incubator-nemo/pull/11#discussion_r176906807
##########
File path:
runtime/master/src/main/java/edu/snu/nemo/runtime/master/scheduler/PendingTaskGroupQueue.java
##########
@@ -36,16 +38,25 @@
/**
* Enqueues a TaskGroup to this PQ.
- * @param scheduledTaskGroup to enqueue.
+ * @param scheduledTaskGroup to add.
*/
- void enqueue(final ScheduledTaskGroup scheduledTaskGroup);
+ void add(final ScheduledTaskGroup scheduledTaskGroup);
Review comment:
Let's change the name of this class to represent it's behavior well. (It is
not a queue anymore.)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
