sanha commented on a change in pull request #2: [NEMO-7] Intra-TaskGroup
pipelining
URL: https://github.com/apache/incubator-nemo/pull/2#discussion_r187038660
##########
File path:
runtime/executor/src/main/java/edu/snu/nemo/runtime/executor/datatransfer/OutputCollectorImpl.java
##########
@@ -85,15 +83,16 @@ public RuntimeEdge getSideInputRuntimeEdge() {
return sideInputRuntimeEdge;
}
+ /**
+ * Set this OutputCollector as having side input for the given child task.
+ *
+ * @param physicalTaskId the id of child task whose side input will be put
into this OutputCollector.
+ */
public void setAsSideInputFor(final String physicalTaskId) {
sideInputReceivers.add(physicalTaskId);
}
public boolean hasSideInputFor(final String physicalTaskId) {
Review comment:
Comment please :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
