seojangho commented on a change in pull request #15: [NEMO-52] Make
SchedulingPolicy Stackable
URL: https://github.com/apache/incubator-nemo/pull/15#discussion_r187789042
##########
File path:
tests/src/test/java/edu/snu/nemo/tests/runtime/master/scheduler/FaultToleranceTest.java
##########
@@ -207,14 +208,17 @@ public void testContainerRemoval() throws Exception {
if (stage.getScheduleGroupIndex() == 0) {
// There are 3 executors, each of capacity 2, and there are 6
TaskGroups in ScheduleGroup 0.
- RuntimeTestUtil.mockSchedulerRunner(pendingTaskGroupCollection,
schedulingPolicy, jobStateManager, false);
+ RuntimeTestUtil.mockSchedulerRunner(pendingTaskGroupCollection,
schedulingPolicy, jobStateManager,
+ executorRegistry, false);
assertTrue(pendingTaskGroupCollection.isEmpty());
stage.getTaskGroupIds().forEach(taskGroupId ->
RuntimeTestUtil.sendTaskGroupStateEventToScheduler(scheduler,
executorRegistry,
taskGroupId, TaskGroupState.State.COMPLETE, 1));
} else if (stage.getScheduleGroupIndex() == 1) {
- // There are 3 executors, each of capacity 2, and there are 2
TaskGroups in ScheduleGroup 1.
- RuntimeTestUtil.mockSchedulerRunner(pendingTaskGroupCollection,
schedulingPolicy, jobStateManager, false);
+ scheduler.onExecutorRemoved("a3");
Review comment:
This scenario improves `FaultToleranceTest` by not relying on the specific
behavior of `RoundRobinSchedulingPolicy`. I recommend describing this
contribution in the PR description.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
