jeongyooneo commented on a change in pull request #20: [NEMO-76] Rename
TaskGroup to Task
URL: https://github.com/apache/incubator-nemo/pull/20#discussion_r189456113
##########
File path:
runtime/master/src/main/java/edu/snu/nemo/runtime/master/JobStateManager.java
##########
@@ -260,39 +260,38 @@ public synchronized void onStageStateChanged(final
String stageId, final StageSt
}
/**
- * Updates the state of a task group.
- * Task group state changes can occur both in master and executor.
+ * Updates the state of a task.
+ * Task state changes can occur both in master and executor.
* State changes that occur in master are
* initiated in {@link
edu.snu.nemo.runtime.master.scheduler.BatchSingleJobScheduler}.
* State changes that occur in executors are sent to master as a control
message,
* and the call to this method is initiated in {@link
edu.snu.nemo.runtime.master.scheduler.BatchSingleJobScheduler}
* when the message/event is received.
- * A task group completion implies completion of all its tasks.
+ * A task completion implies completion of all its tasks.
*
- * @param taskGroupId the ID of the task group.
- * @param newState the new state of the task group.
+ * @param taskId the ID of the task.
+ * @param newState the new state of the task.
*/
- public synchronized void onTaskGroupStateChanged(final String taskGroupId,
- final TaskGroupState.State
newState) {
- final StateMachine taskGroupState =
idToTaskGroupStates.get(taskGroupId).getStateMachine();
- final String stageId =
RuntimeIdGenerator.getStageIdFromTaskGroupId(taskGroupId);
+ public synchronized void onTaskStateChanged(final String taskId, final
TaskState.State newState) {
+ final StateMachine taskState =
idToTaskStates.get(taskId).getStateMachine();
+ final String stageId = RuntimeIdGenerator.getStageIdFromTaskId(taskId);
LOG.debug("Task Group State Transition: id {}, from {} to {}",
Review comment:
Task Group -> Task?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
