jeongyooneo commented on a change in pull request #21: [NEMO-46] Make the operations on ExecutorRegistry atomic URL: https://github.com/apache/incubator-nemo/pull/21#discussion_r189774748
########## File path: runtime/master/src/main/java/edu/snu/nemo/runtime/master/JobStateManager.java ########## @@ -65,6 +65,11 @@ private final Map<String, StageState> idToStageStates; private final Map<String, TaskState> idToTaskStates; + /** + * Keeps track of the number of schedule attempts for each task. + */ + private final Map<String, Integer> taskIdToCurrentAttempt; Review comment: As far as I understood through the codebase, `Task`'s attemptIdx is set/updated in a single place, i.e. `JobStateManger`'s `taskIdToCurrentAttempt`, and it is read-only in other classes. Could you make it explicit in the comment? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
