jeongyooneo commented on a change in pull request #26: [NEMO-78] Rename 
PhysicalStage to Stage
URL: https://github.com/apache/incubator-nemo/pull/26#discussion_r192966782
 
 

 ##########
 File path: 
runtime/common/src/main/java/edu/snu/nemo/runtime/common/plan/StageEdge.java
 ##########
 @@ -57,14 +56,14 @@
    * @param coder the coder for enconding and deconding.
    * @param isSideInput whether or not the edge is a sideInput edge.
    */
-  public PhysicalStageEdge(final String runtimeEdgeId,
-                           final ExecutionPropertyMap edgeProperties,
-                           final IRVertex srcVertex,
 
 Review comment:
   Could you explain more on `srcVertex` and `dstVertex` of `StageEdge` in the 
Constructor comment?
   For example like the following: 
   
   > srcVertex: IRVertex in the source stage that this StageEdge connects from.
   dstVertex: IRVertex in the destination stage that this StageEdge connects to.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to