wonook commented on a change in pull request #28: [NEMO-12] Frontend support
for Scala Spark
URL: https://github.com/apache/incubator-nemo/pull/28#discussion_r193322788
##########
File path:
compiler/frontend/spark/src/main/java/edu/snu/nemo/compiler/frontend/spark/sql/Dataset.java
##########
@@ -73,6 +74,24 @@ private Dataset(final SparkSession sparkSession, final
LogicalPlan logicalPlan,
return JavaRDD.of((SparkSession) super.sparkSession(), this);
}
+ /**
+ * @return a Spark RDD from this dataset.
+ */
+ public org.apache.spark.rdd.RDD<T> sparkRDD() {
Review comment:
I think for this bit, we should be a little more careful about replacing the
`super.rdd()` function with `sparkRDD()` and using `rdd()` as something of our
own. In my opinion, they should be either switched around or should do the same
thing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
