sanha commented on a change in pull request #30: [NEMO-63] On-demand dynamic
optimization metric aggregation
URL: https://github.com/apache/incubator-nemo/pull/30#discussion_r194611550
##########
File path:
common/src/main/java/edu/snu/nemo/common/ir/vertex/MetricCollectionBarrierVertex.java
##########
@@ -71,21 +74,28 @@ public void setDAGSnapshot(final DAG<IRVertex, IREdge>
dag) {
/**
* Method for accumulating metrics in the vertex.
- * @param key metric key, e.g. ID of the partition.
- * @param values metric values, e.g. the block size information of the
partition data.
+ * @param metric the block size information of the partition.
*/
- public void accumulateMetric(final String key, final List<T> values) {
- metricData.putIfAbsent(key, values);
+ public void updateMetricData(final T metric) {
+ metricData = metric;
}
/**
* Method for retrieving metrics from the vertex.
* @return the accumulated metric data.
*/
- public Map<String, List<T>> getMetricData() {
+ public T getMetricData() {
return metricData;
}
+ public void addBlockId(final String blockId) {
+ blockIds.add(blockId);
+ }
+
+ public List<String> getBlockIds() {
Review comment:
Please add comments to this method.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
