johnyangk commented on a change in pull request #68: [NEMO-125] Fix data loss 
bug caused by SailfishSchedulingPolicy
URL: https://github.com/apache/incubator-nemo/pull/68#discussion_r199701710
 
 

 ##########
 File path: 
runtime/executor/src/main/java/edu/snu/nemo/runtime/executor/data/DataUtil.java
 ##########
 @@ -234,18 +228,20 @@ public InputStreamIterator(final Iterator<InputStream> 
inputStreams,
      *
      * @param inputStreams The streams to read data from.
      * @param serializer   The serializer.
-     * @param limit        The number of elements from the {@link InputStream}.
+     * @param limit        The bytes to read from the {@link InputStream}.
      */
     public InputStreamIterator(
         final Iterator<InputStream> inputStreams,
         final Serializer<?, T> serializer,
-        final long limit) {
+        final int limit) {
       if (limit < 0) {
         throw new IllegalArgumentException("Negative limit not allowed.");
       }
       this.inputStreams = inputStreams;
       this.serializer = serializer;
       this.limit = limit;
+      //this.limit = -1;
+      //@param limit        The number of elements from the {@link 
InputStream}.
 
 Review comment:
   Remove?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to