johnyangk commented on a change in pull request #62: [NEMO-71] Add LocationShareAssignmentPass and Example Application URL: https://github.com/apache/incubator-nemo/pull/62#discussion_r199788962
########## File path: common/src/main/java/edu/snu/nemo/common/ir/vertex/executionproperty/LocationSharesProperty.java ########## @@ -0,0 +1,42 @@ +/* + * Copyright (C) 2018 Seoul National University + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package edu.snu.nemo.common.ir.vertex.executionproperty; + +import edu.snu.nemo.common.ir.executionproperty.VertexExecutionProperty; + +import java.util.HashMap; + +/** + * LocationShares ExecutionProperty. + */ +public final class LocationSharesProperty extends VertexExecutionProperty<HashMap<String, Integer>> { + /** + * Default constructor. + * @param value the map from location to the number of TaskGroups that must be executed in that location + */ + public LocationSharesProperty(final HashMap<String, Integer> value) { Review comment: Would it be better to use Map<String, Float> to track fractions, rather than the actual number of tasks? If not, this property probably needs to be updated whenever the Parallelism property is updated to ensure correct behavior. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
