wynot12 commented on issue #69: [NEMO-2, 106, 117] Remove the /tests directory URL: https://github.com/apache/incubator-nemo/pull/69#issuecomment-403726944 @wonook Thanks for review and suggestion! First, I didn't know `plangenerator` module is also for tests, since it's name is confusing. And they cannot be a single module due to cyclic dependency (runtime-test -> runtime-master -> runtime-plangenerator). Second, I'd also love to separate tests more clean as you pointed out, but several tests have complex dependencies as I described in the PR description. Especially, `nemo.compiler.optimizer.pass.compiletime` tests cannot go to corresponding module (nemo-compiler-optimizer). It's because those tests use `JobLauncher` in `nemo-client` package. `nemo-client` has dependency on `nemo-compiler-optimizer` module again, which means cyclic dependency. Please refer https://docs.google.com/presentation/d/1S5EIFBDT7INfCTwRAW3ZcxrlGxVdDuvfTnyu1LRiFQ0/edit?usp=sharing
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
