shpark commented on a change in pull request #81: [NEMO-151] Add OutputWriters
for additional tagged outputs
URL: https://github.com/apache/incubator-nemo/pull/81#discussion_r203946134
##########
File path:
compiler/optimizer/src/main/java/edu/snu/nemo/compiler/optimizer/pass/compiletime/reshaping/SailfishRelayReshapingPass.java
##########
@@ -60,6 +62,21 @@ public SailfishRelayReshapingPass() {
// before the vertex receiving shuffled data.
final OperatorVertex iFileMergerVertex = new OperatorVertex(new
RelayTransform());
iFileMergerVertex.getExecutionProperties().put(SkipSerDesProperty.of());
+
+ // Update additional tagged output property of the source vertex
if necessary.
Review comment:
Due to current implementation that relies on execution property to route
additional outputs to different children, we must update the execution property
to send data to the inserted vertex, properly. Even if we store information
directly to the vertex and edges, without using execution property (similar to
`isSideInput()` for runtime edges), we should always update destination
information every time we insert a new vertex. In this context,
[NEMO-162](https://issues.apache.org/jira/projects/NEMO/issues/NEMO-162)
suggest that we provide a high-level api for inserting a new vertex, which can
perform these kinds of checks internally
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
