johnyangk commented on a change in pull request #89: [NEMO-175] Remove
'taskInfo', add Scheduler#completeHeldTask
URL: https://github.com/apache/incubator-nemo/pull/89#discussion_r208131600
##########
File path:
runtime/master/src/main/java/edu/snu/nemo/runtime/master/scheduler/Scheduler.java
##########
@@ -47,10 +46,16 @@ void scheduleJob(PhysicalPlan physicalPlan,
* Receives and updates the scheduler with a new physical plan for a job.
* @param jobId the ID of the job to change the physical plan.
* @param newPhysicalPlan new physical plan for the job.
- * @param taskInfo pair containing the information of the executor id and
task id to mark as complete after the
- * update.
*/
- void updateJob(String jobId, PhysicalPlan newPhysicalPlan, Pair<String,
String> taskInfo);
+ void updateJob(String jobId, PhysicalPlan newPhysicalPlan);
+
+ /**
+ * Completes a task which is in ON_HOLD state.
+ *
+ * @param taskId id of the task
+ * @param executorId id of the executor which executes the task
+ */
+ void completeHeldTask(String taskId, String executorId);
Review comment:
private method?
Compared to the other methods, this one seems very specific.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
