johnyangk commented on a change in pull request #88: [NEMO-138] Rule-based
policy
URL: https://github.com/apache/incubator-nemo/pull/88#discussion_r208202574
##########
File path:
runtime/common/src/main/java/edu/snu/nemo/runtime/common/optimizer/pass/runtime/RuntimePass.java
##########
@@ -16,21 +16,23 @@
package edu.snu.nemo.runtime.common.optimizer.pass.runtime;
import edu.snu.nemo.common.eventhandler.RuntimeEventHandler;
+import edu.snu.nemo.common.pass.Pass;
import edu.snu.nemo.runtime.common.plan.PhysicalPlan;
import java.io.Serializable;
import java.util.Set;
import java.util.function.BiFunction;
/**
- * Interface for dynamic optimization passes, for dynamically optimizing a
physical plan.
+ * Abstract class for dynamic optimization passes, for dynamically optimizing
a physical plan.
* It is a BiFunction that takes an original physical plan and metric data, to
produce a new physical plan
* after dynamic optimization.
* @param <T> type of the metric data used for dynamic optimization.
*/
-public interface RuntimePass<T> extends BiFunction<PhysicalPlan, T,
PhysicalPlan>, Serializable {
+public abstract class RuntimePass<T> extends Pass
+ implements BiFunction<PhysicalPlan, T, PhysicalPlan>, Serializable {
Review comment:
drop `Serializable`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
