seojangho closed pull request #98: [NEMO-118] Implement Skipping (De)Serialization by ExecutionProperty URL: https://github.com/apache/incubator-nemo/pull/98
This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/common/src/main/java/edu/snu/nemo/common/ir/vertex/executionproperty/SkipSerDesProperty.java b/common/src/main/java/edu/snu/nemo/common/ir/vertex/executionproperty/SkipSerDesProperty.java deleted file mode 100644 index f9668eddd..000000000 --- a/common/src/main/java/edu/snu/nemo/common/ir/vertex/executionproperty/SkipSerDesProperty.java +++ /dev/null @@ -1,42 +0,0 @@ -/* - * Copyright (C) 2018 Seoul National University - * - * Licensed under the Apache License, Version 2.0 (the "License"); - * you may not use this file except in compliance with the License. - * You may obtain a copy of the License at - * - * http://www.apache.org/licenses/LICENSE-2.0 - * - * Unless required by applicable law or agreed to in writing, software - * distributed under the License is distributed on an "AS IS" BASIS, - * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. - * See the License for the specific language governing permissions and - * limitations under the License. - */ -package edu.snu.nemo.common.ir.vertex.executionproperty; - -import edu.snu.nemo.common.ir.executionproperty.VertexExecutionProperty; - -/** - * Attaching this property makes runtime to skip serialization and deserialization for the vertex input and output. - * TODO #118: Implement Skipping (De)Serialization by ExecutionProperty - */ -public final class SkipSerDesProperty extends VertexExecutionProperty<Boolean> { - - private static final SkipSerDesProperty SKIP_SER_DES_PROPERTY = new SkipSerDesProperty(); - - /** - * Constructor. - */ - private SkipSerDesProperty() { - super(true); - } - - /** - * Static method exposing the constructor. - * @return the execution property. - */ - public static SkipSerDesProperty of() { - return SKIP_SER_DES_PROPERTY; - } -} diff --git a/compiler/optimizer/src/main/java/edu/snu/nemo/compiler/optimizer/pass/compiletime/reshaping/LargeShuffleRelayReshapingPass.java b/compiler/optimizer/src/main/java/edu/snu/nemo/compiler/optimizer/pass/compiletime/reshaping/LargeShuffleRelayReshapingPass.java index 0e476ffa1..7abee7e0d 100644 --- a/compiler/optimizer/src/main/java/edu/snu/nemo/compiler/optimizer/pass/compiletime/reshaping/LargeShuffleRelayReshapingPass.java +++ b/compiler/optimizer/src/main/java/edu/snu/nemo/compiler/optimizer/pass/compiletime/reshaping/LargeShuffleRelayReshapingPass.java @@ -23,7 +23,6 @@ import edu.snu.nemo.common.ir.edge.IREdge; import edu.snu.nemo.common.ir.vertex.IRVertex; import edu.snu.nemo.common.ir.vertex.OperatorVertex; -import edu.snu.nemo.common.ir.vertex.executionproperty.SkipSerDesProperty; import edu.snu.nemo.common.ir.vertex.transform.RelayTransform; import java.util.Collections; @@ -59,7 +58,6 @@ public LargeShuffleRelayReshapingPass() { // Insert a merger vertex having transform that write received data immediately // before the vertex receiving shuffled data. final OperatorVertex iFileMergerVertex = new OperatorVertex(new RelayTransform()); - iFileMergerVertex.getExecutionProperties().put(SkipSerDesProperty.of()); builder.addVertex(iFileMergerVertex); final IREdge newEdgeToMerger = new IREdge(CommunicationPatternProperty.Value.Shuffle, ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
