taegeonum closed pull request #155: [NEMO-275] Eager Garbage Collection for
GroupByKey
URL: https://github.com/apache/incubator-nemo/pull/155
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/compiler/frontend/beam/src/main/java/org/apache/nemo/compiler/frontend/beam/transform/GroupByKeyTransform.java
b/compiler/frontend/beam/src/main/java/org/apache/nemo/compiler/frontend/beam/transform/GroupByKeyTransform.java
index 4e8edf06c..0f4cf5b64 100644
---
a/compiler/frontend/beam/src/main/java/org/apache/nemo/compiler/frontend/beam/transform/GroupByKeyTransform.java
+++
b/compiler/frontend/beam/src/main/java/org/apache/nemo/compiler/frontend/beam/transform/GroupByKeyTransform.java
@@ -61,10 +61,12 @@ public void close() {
if (keyToValues.isEmpty()) {
LOG.warn("Beam GroupByKeyTransform received no data!");
} else {
- keyToValues.entrySet().stream().map(entry ->
- WindowedValue.valueInGlobalWindow(KV.of(entry.getKey(),
entry.getValue())))
- .forEach(outputCollector::emit);
- keyToValues.clear();
+ final Iterator<Map.Entry<Object, List>> iterator =
keyToValues.entrySet().iterator();
+ while (iterator.hasNext()) {
+ final Map.Entry<Object, List> entry = iterator.next();
+
outputCollector.emit(WindowedValue.valueInGlobalWindow(KV.of(entry.getKey(),
entry.getValue())));
+ iterator.remove();
+ }
}
}
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
